FXIOS-16383 Fix deletion of non-Disconnect records - #226
Merged
Conversation
leplatrem
approved these changes
Jul 23, 2026
bvandersloot-mozilla
approved these changes
Jul 24, 2026
bvandersloot-mozilla
left a comment
bvandersloot-mozilla
left a comment
There was a problem hiding this comment.
This is a little confusing, but seems wise. Making it explicit that disconnect records are added by another pipeline would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
Fixes an issue with one of the scripts publishing our shavar/disconnect files to Remote Settings, which resulted in non-Disconnect records being automatically deleted incorrectly.
Jira
Currently tracked in: https://mozilla-hub.atlassian.net/browse/FXIOS-16383
Acceptance Criteria
ad-blockrecord is no longer deleted when the nightly chronjob is run on backendNotes
Context and additional information: https://mozilla.slack.com/archives/C0559DDDPQF/p1784564144204479
/cc @issammani @artines1 @leplatrem