-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set additional_deletion_requests_v1 retention to 775 days #6901
Open
BenWu
wants to merge
2
commits into
main
Choose a base branch
from
benwu/add-del-req-retention
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ owners: | |
| - [email protected] | ||
| labels: | ||
| schedule: daily | ||
| table_type: client_level | ||
| scheduling: | ||
| dag_name: bqetl_org_mozilla_focus_derived | ||
| depends_on_past: false | ||
|
|
@@ -16,3 +17,4 @@ bigquery: | |
| type: day | ||
| field: submission_timestamp | ||
| require_partition_filter: false | ||
| expiration_days: 775 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ owners: | |
| - [email protected] | ||
| labels: | ||
| schedule: daily | ||
| table_type: client_level | ||
| scheduling: | ||
| dag_name: bqetl_org_mozilla_focus_derived | ||
| depends_on_past: false | ||
|
|
@@ -16,3 +17,4 @@ bigquery: | |
| type: day | ||
| field: submission_timestamp | ||
| require_partition_filter: false | ||
| expiration_days: 775 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ owners: | |
| - [email protected] | ||
| labels: | ||
| schedule: daily | ||
| table_type: client_level | ||
| scheduling: | ||
| dag_name: bqetl_org_mozilla_focus_derived | ||
| depends_on_past: false | ||
|
|
@@ -16,3 +17,4 @@ bigquery: | |
| type: day | ||
| field: submission_timestamp | ||
| require_partition_filter: false | ||
| expiration_days: 775 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenWu should we define this value inside
bqetl_project.yamlwhich could be used as a default value when retention policy is enabled on a table? From my understanding most tables should share the same retention policy. If need be we could always allow for explicitly overwriting it in the metadata.yaml.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO since retention is still new, it would be better to have retention explicitly set for every table rather than having a default value so there are fewer surprises. When we get to a point where we all assume derived client tables default to 775 days then we can set a default. There's also going to be a check that retention is set so all the existing tables should be covered