Bug 2036752: Use correct registry path for PreXULSkeletonUI in enterprise builds and allow skeleton UI when MOZ_BYPASS_FELT is set#808
Merged
victhorlopez merged 1 commit intoJun 8, 2026
Conversation
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
from
92de57f to
b2b5414
Compare
victhorlopez
changed the title
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
from
b2b5414 to
3eecd0b
Compare
victhorlopez
changed the title
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
from
3eecd0b to
0b33c33
Compare
victhorlopez
commented
May 4, 2026
victhorlopez
added a commit
to victhorlopez/enterprise-firefox
that referenced
this pull request
May 4, 2026
lissyx
reviewed
May 5, 2026
lissyx
reviewed
May 5, 2026
victhorlopez
changed the title
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
2 times, most recently
from
5c48c8c to
50b6afd
Compare
victhorlopez
added
test-greening
lissyx
reviewed
May 5, 2026
lissyx
approved these changes
May 5, 2026
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
4 times, most recently
from
3c02f64 to
23a8412
Compare
victhorlopez
added a commit
to victhorlopez/enterprise-firefox
that referenced
this pull request
May 6, 2026
victhorlopez
commented
May 7, 2026
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
4 times, most recently
from
c5ade23 to
d6ddca4
Compare
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
7 times, most recently
from
fe14d6c to
34bc66d
Compare
victhorlopez
commented
May 19, 2026
Mossop
requested changes
May 19, 2026
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
from
34bc66d to
5a7473a
Compare
victhorlopez
force-pushed
the
bug/PreXULSkeletonUI
branch
from
5a7473a to
a29648e
Compare
Mossop
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugzilla: Bug-2036752
In enterprise builds, the PreXULSkeletonUI startup check requires the -felt flag to be present, but mochitests don't pass this flag, so adding MOZ_BYPASS_FELT as an alternative allows the skeleton UI to run during tests and prevents browser_preXULSkeletonUIRegistry from failing on enterprise builds.
Additionally the MOZ_APP_BASENAME is used in C++ to compute the registry path, vs a hardcoded "firefox" on the test, which fails on enterprise
Dependencies / Related Issues
Screenshots
Testing
See test pass with latest changes
See test fail without changes