Skip to content

Commit e9f9fb9

Browse files
committed
update pyproject, skip addons for win
2 parents 933de81 + c525d72 commit e9f9fb9

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

dev_pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ markers = [
1212
"ci: basic tests to run in ci",
1313
"locale_de: tests run in DE locale versions",
1414
"locale_fr: tests run in FR locale versions",
15-
"locale_gb: tests run in GB locale versions"
15+
"locale_gb: tests run in GB locale versions",
16+
"noxvfb: tests that should not run in xvfb sessions"
1617
]
1718

1819
[tool.ruff]

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ markers = [
1212
"ci: basic tests to run in ci",
1313
"locale_de: tests run in DE locale versions",
1414
"locale_fr: tests run in FR locale versions",
15-
"locale_gb: tests run in GB locale versions"
15+
"locale_gb: tests run in GB locale versions",
16+
"noxvfb: tests that should not run in xvfb sessions"
1617
]
1718

1819
[tool.ruff]

tests/address_bar_and_search/test_addon_suggestion.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import pytest
2+
import platform
23
from selenium.webdriver import Firefox
34
from selenium.webdriver.support import expected_conditions as EC
45

@@ -23,6 +24,7 @@ def test_case():
2324
return "3029292"
2425

2526

27+
@pytest.mark.skipif(platform.system().lower().startswith("win"), "Bug 1971323")
2628
@pytest.mark.noxvfb
2729
def test_addon_suggestion_based_on_search_input(driver: Firefox):
2830
"""
@@ -34,10 +36,7 @@ def test_addon_suggestion_based_on_search_input(driver: Firefox):
3436
for input_text, addon_slug in INPUT_TO_ADDON_NAME.items():
3537
nav.type_in_awesome_bar(input_text)
3638

37-
if not nav.element_visible("addon-suggestion"):
38-
raise AssertionError(
39-
f"Addon suggestion not visible for input: '{input_text}'"
40-
)
39+
4140

4241
nav.select_element_in_nav("addon-suggestion")
4342
expected_url = f"{ADDONS_BASE_URL}{addon_slug}/"

0 commit comments

Comments
 (0)