Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anca/ Improve l10n tests readability #543

Merged
merged 10 commits into from
Apr 3, 2025
Merged

Conversation

soncuteanca
Copy link
Collaborator

@soncuteanca soncuteanca commented Mar 28, 2025

Relevant Links

Bugzilla: 1955551
TestRail: N/A

Description of Code / Doc Changes

  • The original test naming was difficult to follow due to inconsistencies and a lack of clear structure. I renamed the tests to establish a logical, sequential order that reflects the step by step flow of how autofill works. Since PyCharm sorts files alphabetically, I used a numbering trick in the filenames to maintain the logical order I wanted. Let me know if you have other ideas for handling this.

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@ben-c-at-moz
Copy link
Collaborator

I suspect the errors here are actually related to caching of certain elements. Try adding "doNotCache" to the "groups" list of the offending elements. I guess it is also possible that there's something inherent in this renaming that's the problem. I recommend running the version of the tests from main to see if they pass. If they have these stale element errors, then it's a caching problem. If they don't it's something related to the renaming.

Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot, but it all looks good!

@soncuteanca soncuteanca merged commit 3d02a58 into main Apr 3, 2025
6 checks passed
@soncuteanca soncuteanca deleted the as/l10n-improve-readability branch April 3, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants