Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracy/ Change selector to class strategy #546

Merged
merged 3 commits into from
Apr 2, 2025
Merged

tracy/ Change selector to class strategy #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bbff8a
Change selector to class strategy
Tracy-Walker Apr 2, 2025
c405923
Mark unstable test
Tracy-Walker Apr 2, 2025
80b01a7
Change to xfail for Firefox bug
Tracy-Walker Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions SELECTOR_INFO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2965,11 +2965,8 @@ Location: Autoplay doorhanger
Path to .json: modules/data/navigation.components.json
```
```
Selector Name: autoplay-permission
Selector Data: blocked-permissions-container
Description: Autoplay permission
Selector Name: checkbox-remember-this-decision
Selector Data: "label.checkbox-label[flex='1']"
Selector Data: "popup-notification-checkbox"
Description: Remember this decision checkbox
Location: Geolocation prompt container in Address bar
Path to .json: modules/data/navigation.components.json
Expand Down
4 changes: 2 additions & 2 deletions modules/data/navigation.components.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,8 @@
},

"checkbox-remember-this-decision": {
"selectorData": "label.checkbox-label[flex='1']",
"strategy": "css",
"selectorData": "popup-notification-checkbox",
"strategy": "class",
"groups": []
},

Expand Down
3 changes: 3 additions & 0 deletions tests/address_bar_and_search/test_addon_suggestion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ def test_case():
return "2234714"


@pytest.mark.xfail(
reason="Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=1958038"
)
def test_addon_suggestion_based_on_search_input(driver: Firefox):
"""
C2234714: Test that add-on suggestions match the URL bar input.
Expand Down