Skip to content

[ci rerun-skip] replace pocket interactions dataset with newtab visits and update exposure_signal #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
Merged

[ci rerun-skip] replace pocket interactions dataset with newtab visits and update exposure_signal #1239

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6572dd5
replace pocket interactions dataset with newtab visits and update exp…
jaredsnyder Nov 18, 2025
d659e2f
add paranthesis
jaredsnyder Nov 18, 2025
fd5e265
remove client_id key
jaredsnyder Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions definitions/firefox_desktop.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2327,20 +2327,17 @@ friendly_name = "Search Tiles Visit Activity Daily"
client_id_column = "legacy_telemetry_client_id"
experiments_column_type = "native"

[data_sources.newtab_visits_pocket_interactions]
[data_sources.newtab_visits]
from_expression = """(
SELECT
e.* EXCEPT (pocket_interactions),
pocket_interactions
*
FROM
`moz-fx-data-shared-prod.telemetry.newtab_visits` e
CROSS JOIN
UNNEST(e.pocket_interactions) AS pocket_interactions
)"""
`moz-fx-data-shared-prod.firefox_desktop.newtab_visits_daily`
)"""
submission_date_column = "submission_date"
description = "Pocket Tiles Visit Activity Daily"
friendly_name = "Pocket Tiles Visit Activity Daily"
client_id_column = "legacy_telemetry_client_id"
description = "Visits-level table or Newtab Homepage Data"
friendly_name = "Newtab Visits Daily"
client_id_column = "client_id"
Copy link
Collaborator

@mikewilli mikewilli Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"client_id" is the default value for client_id_column (the default values are derived from this enum), so you don't need to specify it if you don't want. If you want to be explicit then feel free to leave it in.

However, you may want to specify that this is to be used as the Glean client ID like so:

glean_client_id_column = "client_id"

This is separate from the client_id_column and was added as a convenience for validating analysis before migrating from legacy to glean identifiers as the default. This parameter is null by default.

Copy link
Contributor Author

@jaredsnyder jaredsnyder Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think it can be removed. Pushed a fix

experiments_column_type = "native"

[data_sources.newtab_clients_daily]
Expand Down
4 changes: 2 additions & 2 deletions jetstream/new-tab-inferred-content-personalization.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ sample_size = 50
name = "first_content_click"
friendly_name = "First Click on any content"
description = "Clients Click on any content at least once"
data_source = "newtab_visits_pocket_interactions"
select_expression = "COALESCE(pocket_interactions.pocket_clicks, 0) > 0"
data_source = "newtab_visits"
select_expression = "is_content_click"
window_end = "analysis_window_end"