Support application/jwt in userinfo endpoint#521
Closed
sergei-maertens wants to merge 2 commits intomozilla:mainfrom
Closed
Support application/jwt in userinfo endpoint#521sergei-maertens wants to merge 2 commits intomozilla:mainfrom
sergei-maertens wants to merge 2 commits intomozilla:mainfrom
Conversation
…ic utility This allows us to re-use the verification functionality for both the access token processing and userinfo response data processing without duplicating the low-level implementation. Notable changes: * the 'none' algorithm is blocked as this is a common exploit vector * added some more documentation about the parameters * added type hints to document expected parameter types * did some slight refactoring/restructuring to make the code type-safe
TODO: address broken tests TODO: add new tests
Contributor
|
Seems legit for the handling of the |
Author
|
@escattone what does it mean that this PR is now closed? |
Contributor
|
Sorry @sergei-maertens, I should have added that I closed this PR since we've already merged #549 and #569 to address #517/#548 for the release we're planning for tomorrow. |
Author
|
Fantastic news! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517
This is an initial draft to spark discussion about implementation details.
Changes:
application/jwtprocessing in the userinfo endpointTopics to discuss:
none?parse_www_authenticate_headerfor the content type header processing, but it kinda borks on a value likeapplication/json; charset=utf-8, so instead I use the (private) utility from therequestslibrary which can be controversial. I don't trust myself enough to correctly and safely parse HTTP headers 😬