Skip to content

Adjust Fastly VCL test with current behaviour #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leplatrem merged 2 commits into from
Mar 9, 2026
Merged

Adjust Fastly VCL test with current behaviour #1208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cd9216
Add message to ease debugging
leplatrem Mar 9, 2026
1df171b
Adjust VCL tests with current behaviour
leplatrem Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 114 additions & 36 deletions bin/test-fastly-vcl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,131 +9,209 @@
NOW_EPOCH_MS = int(time.time() * 1000)
OLD_EPOCH_MS = NOW_EPOCH_MS - 30 * 86400 * 1000 # 30 days ago

print(f"Testing {SERVER_URL} with User-Agent: {USER_AGENT}")
print("Current time (epoch ms):", NOW_EPOCH_MS)
print("Old time (epoch ms):", OLD_EPOCH_MS)


@pytest.mark.parametrize(
("url", "expected"),
("url", "expected", "message"),
[
("/", 307),
("/v1", 307),
("/v1/", 200),
("/v2", 307),
("/v2/", 200),
("/v1/boo", 406),
("/v1/cert-chains", 406),
("/v1/buckets", 200),
("/v1/buckets/main", 200),
("/v1/buckets/main/collections", 200),
("/v1/buckets/main/collections/regions", 200),
("/v1/buckets/main/collections/regions/records", 200),
("/v1/buckets/main/collections/regions/changeset", 400),
("/v1/buckets/main/collections/regions/changeset?_expected=0", 200),
("/v1/buckets/main/collections/regions/changeset?_expected=0&_since=0", 200),
("/", 307, "Root URL redirects to /v1/"),
("/v1", 307, "Trailing slash is required for /v1/"),
("/v1/", 200, "Base API URL should be accessible"),
("/v2", 307, "Trailing slash is required for /v2/"),
("/v2/", 200, "Base API URL should be accessible"),
("/v1/boo", 406, "Unknown endpoint should return 406"),
("/v1/cert-chains", 406, "Unknown endpoint should return 406"),
("/v1/buckets", 200, "Buckets list"),
("/v1/buckets/main", 200, "Main bucket"),
("/v1/buckets/main/collections", 200, "Collections list"),
("/v1/buckets/main/collections/regions", 200, "Collection metadata"),
("/v1/buckets/main/collections/regions/records", 200, "Collection records"),
(
"/v1/buckets/main/collections/regions/changeset",
400,
"Missing _expected should return 400",
),
(
"/v1/buckets/main/collections/regions/changeset?_expected=0",
200,
"Changeset with expected=0",
),
(
"/v1/buckets/main/collections/regions/changeset?_expected=0&_since=0",
200,
"Changeset with expected=0 and since=0",
),
(
f"/v1/buckets/main/collections/regions/changeset?_expected={NOW_EPOCH_MS}",
200,
"Changeset with current timestamp as _expected should return 200",
),
(
f'/v1/buckets/main/collections/regions/changeset?_expected="{NOW_EPOCH_MS}"',
200,
"Changeset with current timestamp as _expected (quoted) should return 200",
),
(
f'/v1/buckets/main/collections/regions/changeset?_expected={NOW_EPOCH_MS}&_since="123"',
200,
"Changeset with current timestamp as _expected and quoted _since should return 200",
),
(
f"/v1/buckets/main/collections/regions/changeset?_expected={NOW_EPOCH_MS}&_since=123",
200,
"Changeset with current timestamp as _expected and unquoted _since should return 200",
),
(
f'/v1/buckets/main/collections/regions/changeset?_expected="{NOW_EPOCH_MS}"&_since="123"',
200,
"Changeset with current timestamp as quoted _expected and quoted _since should return 200",
),
(
f'/v1/buckets/main/collections/regions/changeset?_expected="{NOW_EPOCH_MS}"&_since=123',
200,
"Changeset with current timestamp as quoted _expected and unquoted _since should return 200",
),
(
'/v1/buckets/main/collections/regions/changeset?_expected="abc"',
200,
), # TODO: should be 400
"TODO: should be 400",
),
(
f'/v1/buckets/main/collections/regions/changeset?_expected="{OLD_EPOCH_MS}"',
200,
"Changeset with old timestamp as quoted _expected should return 307",
),
(
f"/v1/buckets/main/collections/regions/changeset?_expected={OLD_EPOCH_MS}",
200,
"Changeset with old timestamp as _expected should return return 200",
),
(
"/v1/buckets/monitor/collections/changes/records",
406,
"Decommissioned monitor/changes records",
),
(
"/v1/buckets/monitor/collections/changes/changeset",
400,
"Missing _expected should return 400 for monitor/changes changeset",
),
(
"/v1/buckets/monitor/collections/changes/changeset?_expected=abc",
400,
"Non-numeric _expected should return 400 for monitor/changes changeset",
),
(
"/v1/buckets/monitor/collections/changes/changeset?_expected=0",
200,
"Changeset with expected=0 should return 200 for monitor/changes changeset",
),
("/v1/buckets/monitor/collections/changes/records", 406),
("/v1/buckets/monitor/collections/changes/changeset", 400),
("/v1/buckets/monitor/collections/changes/changeset?_expected=abc", 400),
("/v1/buckets/monitor/collections/changes/changeset?_expected=0", 200),
(
f"/v1/buckets/monitor/collections/changes/changeset?_expected={NOW_EPOCH_MS}",
200,
"Changeset with current timestamp as _expected should return 200 for monitor/changes changeset",
),
(
f'/v1/buckets/monitor/collections/changes/changeset?_expected="{NOW_EPOCH_MS}"',
200,
307,
"Changeset with current timestamp as quoted _expected should return 200 for monitor/changes changeset",
),
(
f'/v1/buckets/monitor/collections/changes/changeset?_expected="{NOW_EPOCH_MS}"&_since="{OLD_EPOCH_MS}"',
307,
"Changeset with current timestamp as quoted _expected and old timestamp as quoted _since should return 307 for monitor/changes changeset",
),
(
f'/v1/buckets/monitor/collections/changes/changeset?_expected={NOW_EPOCH_MS}&_since="{NOW_EPOCH_MS}"',
200,
"Changeset with current timestamp as _expected and quoted current timestamp as _since should return 200 for monitor/changes changeset",
),
(
f"/v1/buckets/monitor/collections/changes/changeset?_expected={NOW_EPOCH_MS}&_since={NOW_EPOCH_MS}",
200,
"Changeset with current timestamp as _expected and current timestamp as _since should return 200 for monitor/changes changeset",
),
(
f'/v1/buckets/monitor/collections/changes/changeset?_expected="{NOW_EPOCH_MS}"&_since="{NOW_EPOCH_MS}"',
200,
307,
"Changeset with current timestamp as quoted _expected redirects to unquoted in monitor/changes changeset",
),
(
f'/v1/buckets/monitor/collections/changes/changeset?_expected="{NOW_EPOCH_MS}"&_since={NOW_EPOCH_MS}',
200,
307,
"Changeset with current timestamp as quoted _expected redirects to unquoted in monitor/changes changeset",
),
("/v2/boo", 406, "Unknown endpoint should return 406"),
("/v2/buckets", 404, "Buckets endpoint should return 404 in v2"),
("/v2/buckets/main", 404, "Main bucket should return 404 in v2"),
(
"/v2/buckets/main/collections",
404,
"Collections endpoint should return 404 in v2",
),
(
"/v2/buckets/main/collections/regions",
404,
"Collection metadata endpoint should return 404 in v2",
),
(
"/v2/buckets/main/collections/regions/records",
404,
"Records endpoint should return 404 in v2",
),
("/v2/boo", 406),
("/v2/buckets", 404),
("/v2/buckets/main", 404),
("/v2/buckets/main/collections", 404),
("/v2/buckets/main/collections/regions", 404),
("/v2/buckets/main/collections/regions/records", 404),
(
"/v2/buckets/main/collections/regions/changeset",
400,
422,
"Missing _expected should return 422 for v2 changeset",
),
(
"/v2/buckets/main/collections/regions/changeset?_expected=0",
200,
"Changeset with expected=0 should return 200 for v2 changeset",
),
("/v2/buckets/main/collections/regions/changeset?_expected=0", 200),
(
f'/v2/buckets/main/collections/regions/changeset?_expected="{NOW_EPOCH_MS}"',
422,
"Quoted _expected should return 422 for v2 changeset",
),
(
f"/v2/buckets/main/collections/regions/changeset?_expected={NOW_EPOCH_MS}",
200,
"Unquoted _expected should return 200 for v2 changeset",
),
(
f'/v2/buckets/monitor/collections/changes/changeset?_expected="{NOW_EPOCH_MS}"',
422,
"Quoted _expected should return 422 for monitor/changes changeset in v2",
),
(
f"/v2/buckets/monitor/collections/changes/changeset?_expected={NOW_EPOCH_MS}",
200,
"Unquoted _expected should return 200 for monitor/changes changeset in v2",
),
(
f'/v2/buckets/monitor/collections/changes/changeset?_expected={NOW_EPOCH_MS}&_since="{OLD_EPOCH_MS}"',
422,
307,
"Quoted old _since should redirect to unfiltered monitor/changes changeset in v2",
),
(
f"/v2/buckets/monitor/collections/changes/changeset?_expected={NOW_EPOCH_MS}&_since={OLD_EPOCH_MS}",
200,
307,
"Unquoted old _since should redirect to unfiltered monitor/changes changeset in v2",
),
],
)
def test_fastly_vcl_responses(url, expected):
def test_fastly_vcl_responses(url, expected, message):
url = f"{SERVER_URL}{url}"
resp = requests.head(url, headers={"User-Agent": USER_AGENT}, allow_redirects=False)
assert resp.status_code == expected, (
url + f" returned {resp.status_code}, expected {expected}"
message
+ "\n"
+ url
+ f" returned {resp.status_code}, expected {expected} (Location: {resp.headers.get('Location', '')})"
)


Expand Down
Loading