Skip to content

RMST-208: introduce the record_cache_minimum_expires_seconds setting#1222

Merged
alexcottner merged 2 commits intomainfrom
rmst-208
Mar 19, 2026
Merged

RMST-208: introduce the record_cache_minimum_expires_seconds setting#1222
alexcottner merged 2 commits intomainfrom
rmst-208

Conversation

@leplatrem
Copy link
Contributor

@leplatrem leplatrem requested a review from a team as a code owner March 19, 2026 17:09
@leplatrem leplatrem changed the title RMST-208: introduce the record_cache_minimum_expires_seconds setting RMST-208: introduce the record_cache_minimum_expires_seconds setting Mar 19, 2026
# - `_expected=0` is used in Desktop client on `.get()` with an empty DB
# https://searchfox.org/firefox-main/rev/fa20ce29b1a82b/services/settings/RemoteSettingsClient.sys.mjs#496
# https://searchfox.org/firefox-main/rev/fa20ce29b1a82b/services/settings/RemoteSettingsClient.sys.mjs#658-666
if cache_bust_value == "0" or cache_bust_value.startswith("9999"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean

@alexcottner alexcottner merged commit 93338f0 into main Mar 19, 2026
12 checks passed
@alexcottner alexcottner deleted the rmst-208 branch March 19, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants