Skip to content
This repository was archived by the owner on Jul 3, 2019. It is now read-only.

WIP: Bug 1137860 - Playing FLVs using VP6Player#2267

Open
yurydelendik wants to merge 4 commits intomozilla:masterfrom
yurydelendik:vp6player
Open

WIP: Bug 1137860 - Playing FLVs using VP6Player#2267
yurydelendik wants to merge 4 commits intomozilla:masterfrom
yurydelendik:vp6player

Conversation

@yurydelendik
Copy link
Contributor

Creates simple SWF that plays FLV files (VP6 and non-VP6). The flvOption setting now has addition options: flash and alwaysflash. The latter affects even non-FLV files -- mostly for testing.

Problem with the extension that FP runs SWF from 'file:///' location however player is hosted at 'resource://shumway/viewer.gfx.html' -- this does not allow to call anything from SWF: SecurityError: Error #2060: Security sandbox violation: ExternalInterface caller file:///Users/{user}/Library/Application Support/Firefox/Profiles/default/extensions/shumway@research.mozilla.org/content/vp6player.swf cannot access resource://shumway/web/viewer.gfx.html. An SWF path in particular user's profile above must be added as trusted location in FP configuration (Mac OSX: System Preferences -> Flash Player -> Advanced -> Trusted Location Settings...)

TODOs:

  • Transparency
  • Properly fail if the extension has no proper security configuration (see above)
  • Preference to expose the flvOption to the extension
  • appendBytes handling
  • implementing support for the video SWF tag (or do it later?)
  • investigate why gfx sandboxing breaks this functionality (http://logs.glob.uno/?c=mozilla%23shumway#c108243)

Review on Reviewable

@yurydelendik yurydelendik changed the title WIP: Playing FLVs using VP6Player WIP: Bug 1137860 - Playing FLVs using VP6Player Jun 3, 2015
@yurydelendik
Copy link
Contributor Author

Related bug https://bugzilla.mozilla.org/show_bug.cgi?id=1137860

Known blockers:

@tbtlr
Copy link

tbtlr commented Oct 14, 2015

Is it worth fixing the remaining TODOs to land this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants