Creation and playback of compressed SWFM files.

[yurydelendik]

Supports DEFLATE and LZMA compression playback. Saved by the inspector SWFM can be compressed using max compression via "utils/compresss.js" tools.

(While chunked processing of the input data is supported, XHR logic needs to be modified to do so).

r? @mbebenita

[mbebenita]

r+ w/ nits resolved.

---

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.

---

^{src/base/dataBuffer.ts, line 168 [r1] (raw file):}
What happens to the bytes between 0 and position? I don't quite understand how this is being used, maybe the name of the function needs to be changed to something more obvious. I would expect compact to operate on the bytes from 0 to position, not position to _length

---

^{src/base/dataBuffer.ts, line 633 [r1] (raw file):}
Why the switch to Uint8Array?

---

^{src/base/dataBuffer.ts, line 643 [r1] (raw file):}
Unlike the previous code, this is now making a copy? If this is the intent we should add a comment to the function.

---

^{src/flash/display/BitmapData.ts, line 797 [r1] (raw file):}
Should we have an assertion here that data.length is a multiple of 4?

---

^{src/gfx/test/recorder.ts, line 285 [r1] (raw file):}
Should all of this code be moved outside of gfx/test?

---

^{src/gfx/test/recorder.ts, line 335 [r1] (raw file):}
Can we create an instance of a class here, instead of using an object literal?

---

Comments from the review on Reviewable.io

[tbtlr]

@yurydelendik are you gonna address Michaels review comments?

[yurydelendik]

Review status: 2 of 5 files reviewed at latest revision, 5 unresolved discussions, some commit checks pending.

---

^{src/base/dataBuffer.ts, line 168 [r1] (raw file):}
Renamed to removeHead().

---

^{src/base/dataBuffer.ts, line 633 [r1] (raw file):}
Make it more "symmetrical" with writeRawBytes.

---

^{src/base/dataBuffer.ts, line 643 [r1] (raw file):}
All our readXxxx operations are making copies of the data. Also making it more useful for the users (in this case swf reader).

---

^{src/flash/display/BitmapData.ts, line 797 [r1] (raw file):}
It's flash API function. We probably check how it works with invalid data and add test. For simplicity of this PR, change is limited to just renaming of the function and fixing the typo.

---

^{src/gfx/test/recorder.ts, line 285 [r1] (raw file):}
So far SWFM functionality was used only for testing. What will be suggestions in terms of location (package and namespace)?

---

Comments from the review on Reviewable.io

[yurydelendik]

Comments addressed

/botio test

[shumway-bot]

From: Bot.io (Main)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/138c5907c63d73a/output.txt

[shumway-bot]

From: Bot.io (Main)

---

Success

Full output at http://areweflashyet.com:8081/138c5907c63d73a/output.txt

Total script time: 12.22 mins

• Lint: Passed
• Reference tests: Passed
• Trace tests: Passed
• AVM2 tests: Passed
• AVM1 trace tests: Passed
• AVM2 ATS tests: Passed
• Perf tests: Passed