Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package-manager): migrate from yarn to pnpm #20

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Javimtib92
Copy link
Contributor

@Javimtib92 Javimtib92 commented Jun 26, 2024

Migration from yarn to pnpm. This migration includes many changes such as:

  • Remove afterInstall (yarn plugin) and move husky to prepare script. Disable it in CI/CD using HUSKY=0 env variable.
  • Remove yarn config files
  • Install dependencies using just install-deps to initialize pnpm-lock.yaml
  • Modify .gitignore and .prettierignore
  • Modify justfile scripts
  • Fix linstaged not respecting ignored files

⚠️ Please checkout to this branch and test it in your system before approving this PR

@Javimtib92 Javimtib92 marked this pull request as draft June 26, 2024 22:29
mikiPP
mikiPP previously approved these changes Jun 26, 2024
@Javimtib92 Javimtib92 force-pushed the feature/IFMD-19-migrate-to-pnpm branch 4 times, most recently from 7554764 to 9edc7e4 Compare June 27, 2024 06:26
@Javimtib92 Javimtib92 marked this pull request as ready for review June 27, 2024 06:28
arnaugomez
arnaugomez previously approved these changes Jun 27, 2024
Copy link
Contributor

@arnaugomez arnaugomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husky has never worked in my local environment, I have always had trouble getting the scripts to run. I hope it will work better with these changes. I will reach out to you or the team if I run into problems.

@Javimtib92 Javimtib92 merged commit edaa0c3 into master Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants