Skip to content

Improve animation on skeleton.tsx #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vanenshi
Copy link

@vanenshi vanenshi commented May 28, 2025

By using the reverse argument in withRepeat, we can have a smoother animation between the pulses

[Docs] (https://docs.swmansion.com/react-native-reanimated/docs/animations/withRepeat#reverse)

Pull Request Template

Description:

Improve animation on the skeleton component
By using the reverse argument in withRepeat, we can have a smoother animation between the pulses

Tested Platforms:

  • Docs
  • Web
  • iOS
  • Android

Affected Apps/Packages:

none

Screenshots:

Notes:

Summary by CodeRabbit

  • Refactor
    • Improved the animation behavior of the Skeleton component for smoother and more efficient fade in and out effects.

By using the `reverse` argument in withRepeat, we can have a smoother animation between the pulses
 
[Docs] (https://docs.swmansion.com/react-native-reanimated/docs/animations/withRepeat#reverse)
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rnr-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:36pm
rnr-showcase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:36pm

Copy link

coderabbitai bot commented May 28, 2025

Walkthrough

The animation logic in the Skeleton UI component was refactored. Instead of chaining two separate timing animations for opacity, the code now uses a single timing animation with a repeat and reverse flag, achieving the same fade in and out effect with a simpler approach.

Changes

File(s) Change Summary
packages/reusables/src/components/ui/skeleton.tsx Refactored animation logic: replaced explicit sequence with a single timing animation using repeat and reverse for opacity changes.

Poem

In the land of shimmer and light,
Skeletons fade in and out of sight.
With code now lean, the pulses gleam,
A single line, a smoother dream.
Animation hops with less to write—
The rabbit’s touch makes UI bright! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c31ca06 and e809eab.

📒 Files selected for processing (1)
  • packages/reusables/src/components/ui/skeleton.tsx (1 hunks)
🔇 Additional comments (1)
packages/reusables/src/components/ui/skeleton.tsx (1)

20-24: LGTM! Excellent refactor using withRepeat's reverse functionality.

The animation logic has been elegantly simplified by utilizing the reverse parameter in withRepeat. This approach replaces the previous sequence-based animation with a single timing animation that automatically reverses, achieving the same smooth pulsing effect with cleaner and more maintainable code.

The implementation correctly:

  • Animates opacity from 1 to 0.5 over 1000ms
  • Automatically reverses back to 1 due to the reverse: true flag
  • Repeats infinitely with -1

This refactor maintains identical visual behavior while improving code readability and potentially performance.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant