load report_store modules using Module::Load instead of relying on

'eval' fix #234
msimerson · May 31, 2024 · 3c1ae11 · 3c1ae11
1 parent ac6d3ad
commit 3c1ae11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Makefile.PL b/Makefile.PL
@@ -70,6 +70,7 @@ my %META = (
         "IO::Socket::SSL" => 0,
         "IO::Uncompress::Gunzip" => 0,
         "IO::Uncompress::Unzip" => 0,
+	"Module::Load" => 0,
         "Net::DNS::Resolver" => 0,
         "Net::IDN::Encode" => 0,
         "Net::IP" => 0,

diff --git a/lib/Mail/DMARC/Report/Store.pm b/lib/Mail/DMARC/Report/Store.pm
@@ -4,6 +4,7 @@ use strict;
 use warnings;
 
 use Carp;
+use Module::Load;
 
 use parent 'Mail::DMARC::Base';
 
@@ -40,7 +41,7 @@ sub backend {
 
     return $self->{$backend} if ref $self->{$backend};
     my $module = "Mail::DMARC::Report::Store::$backend";
-    eval "use $module";    ## no critic (Eval)
+    load $module;
     if ($@) {
         croak "Unable to load backend $backend: $@\n";
     }