-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a stringify method to the Policy class #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimerson
reviewed
Dec 10, 2024
msimerson
reviewed
Dec 10, 2024
Co-authored-by: Matt Simerson <[email protected]>
Co-authored-by: Matt Simerson <[email protected]>
msimerson
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the contribution!
msimerson
reviewed
Dec 10, 2024
simplify string concatenation (and avoid cleanup at the end)
test fix
Merged
msimerson
added a commit
that referenced
this pull request
Feb 3, 2025
- consider localhost as invalid domain #255 - add a stringify method to the Policy class #253 - lower case domains passed to is_valid_domain #252 - lower case match from and envelope-from domains #249 - Change validation result for RFC7489 6.6.3 step 6.2 #248 - point README links to search.cpan.org #240 - sender: set options when creating new sender object #239 - permit storage of UTF-8 chars in MySQL DB #238 - load report_store modules using Module::Load #237 - create an email message with a proper Message-ID #236 - imap: only use port 143 if requested #235 - find_psl_file: fix duplicate share in path #232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a stringify method to the Policy class, issue #243