Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gt table object output #23

Merged
merged 20 commits into from
Feb 16, 2025
Merged

Implement gt table object output #23

merged 20 commits into from
Feb 16, 2025

Conversation

stefur
Copy link
Collaborator

@stefur stefur commented Feb 5, 2025

A first draft for #18. Still missing masking, totals and theming.

@stefur
Copy link
Collaborator Author

stefur commented Feb 6, 2025

Current progress:

penguins |>
    select(island, sex, species) |>
    ivo_table_gt(title = "Penguins!", subtitle = "So many penguins", source_note = "Sauce: Secret")

image

@stefur stefur force-pushed the gt branch 2 times, most recently from ca3960f to c148c7c Compare February 9, 2025 18:58
@mthulin
Copy link
Owner

mthulin commented Feb 10, 2025

Starting to look really good! Do you want to add a vignette for this or shall I?

@stefur
Copy link
Collaborator Author

stefur commented Feb 10, 2025

Starting to look really good! Do you want to add a vignette for this or shall I?

Yes, that would be great!

@stefur stefur marked this pull request as ready for review February 10, 2025 20:29
@mthulin
Copy link
Owner

mthulin commented Feb 13, 2025

I think this is ready to be released now. Anything more you want to add @stefur ?

@stefur
Copy link
Collaborator Author

stefur commented Feb 13, 2025

Nothing more for the moment. I do have things like number formatting and highlighting columns/rows on the list for the future.

@stefur
Copy link
Collaborator Author

stefur commented Feb 16, 2025

Fixed a bug related to masking of sums and implemented formatting with thousand separator. Now I'm going to go ahead and merge. :)

@stefur stefur merged commit fa2f35b into mthulin:main Feb 16, 2025
6 checks passed
@stefur stefur deleted the gt branch February 16, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants