Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sparql client dependency #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rahien
Copy link

@Rahien Rahien commented Dec 30, 2024

This removes the dependency on sparql-client-2, which is deprecated, unmaintained and uses the deprecated request library.

Instead, it uses digest-fetch to perform a regular fetch request (with support for sparql endpoints with authentication). This approach was taken from nvdks work on the mu-auth-sudo library: lblod/mu-auth-sudo#10

It also includes:

  • the retry mechanism that was used in mu-auth-sudo, defaults to disabled
  • bump of nodemon, which brings the number of npm audit warnings to 0
  • the SPARQL template tag as it was defined by sparql-client-2

The exposed api of mu remains unchanged with this change.

@nvdk
Copy link
Member

nvdk commented Jan 8, 2025

Huzaa! 🎆

@nvdk
Copy link
Member

nvdk commented Jan 16, 2025

this fixes #69, just adding it here so the issue is linked

@erikap
Copy link
Member

erikap commented Feb 18, 2025

This PR needs an update to support the mu-auth-scope and mu-auth-sudo options introduced in 56e185e . This feature is currently available in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants