[DataGrid] Extract getRowId API method as a selector
#16487
+165
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
bug 🐛
MBilalShafi
commented
Feb 6, 2025
| @@ -112,18 +113,11 @@ export const useGridRows = ( | |||
| [apiRef], | |||
| ); | |||
|
|
|||
| const getRowIdProp = props.getRowId; | |||
| const getRowId = React.useCallback<GridRowApi['getRowId']>( | |||
There was a problem hiding this comment.
Any thoughts about deprecating it in favor of the added utility?
Deprecated in favor of the new selector gridRowIdSelector
We could remove all internal instances later.
|
Deploy preview: https://deploy-preview-16487--material-ui-x.netlify.app/ |
romgrk
reviewed
Feb 6, 2025
packages/x-data-grid-premium/src/hooks/features/aggregation/wrapColumnWithAggregation.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Feb 6, 2025
packages/x-data-grid-premium/src/hooks/features/aggregation/createAggregationLookup.ts
Outdated
Show resolved
Hide resolved
MBilalShafi
changed the title
getRowId API method as static functiongetRowId API method as a selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fixes #16103
Fixes #16413
Better fix for #14691
Reuses the props state logic initially committed in #12343