Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brushing to the legend to limit domains of mapped variables #242

Merged
merged 13 commits into from
Jun 18, 2021

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Jun 10, 2021

Closes #184
Closes #186

In this PR, I'm adding brushing support for the legend charts. I've added support for glyphs (must be categorical), numeric node color, numeric link color, node size (must be numeric), link width (must be numeric). The chart brushing updates domains as necessary and is reflected in the visualization. There are a couple of other brushing interactions that I've pushed to issues for another PR -- I didn't want to make this too long. Once I've added the additional mappings, we could likely refactor this to reduce the duplication of some common logic (#248).

Many TODOS:

@JackWilb JackWilb changed the title [WIP] Add brushing to the legend to limit domains of mapped variables Add brushing to the legend to limit domains of mapped variables Jun 17, 2021
@JackWilb JackWilb marked this pull request as ready for review June 17, 2021 23:50
@JackWilb JackWilb merged commit 0f8db9b into master Jun 18, 2021
@JackWilb JackWilb deleted the brushing branch June 18, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using a watchEffect for legend axis rendering Add back brushing to legend charts
1 participant