-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AQL Table Creation UI #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlmightyYakob sorry that I'm just getting to this review. I love it so far, but have a couple thoughts. Let me know if you need clarification on anything I flesh out below
1.) Would it make sense to make the textarea where the AQL is written to take up the full screen (except the sidebars and headerbar of course), and maybe have controls for dark theme text field. I think what you have there is a monospaced/code font, right (I was gonna suggest it if not)?
2.) I'm not sure the right sidebar needs to be done with expansion panels. What if it were 3 evenly sized cards, with separate headings, and lists inside that have scroll bars if the content is too long.
3.) The 3 buttons at the bottom. Can we make the cancel button have the text
prop? We also don't really use green buttons anywhere, so can we make the green button grey darken-2
or 3
?
I'll let you know if I come up with anything else.
Good idea.
By cancel, you mean the red |
48cd947
to
19ad3d2
Compare
I thought taking up the entire area between the two sidebars with a dark theme text box, similar to what you'd see in your code editor would be neat. Not necessary. I think a happy medium would be using a dark theme text box and removing the elevation.
Yeah that button. My concern wasn't really about matching the buttons to the theme. There are two schools of thought on secondary action buttons like "cancel" or "clear" or "delete." There are those that feel that they need to have more attention called to them and be colored appropriately in order to let users know "do not click unless you really mean to." (I typically like this school of thought for the "delete" action, but that's pretty much the only one) The school of thought I usually follow is to remove the emphasis from them. The user will typically then ignore that action unless they really need it. Additionally I find it a bit more aesthetically pleasing. Not trying to sound pretentious, but I always call them skittles buttons when there's multicolored action buttons. That said, that's just my opinion, and neither school of thought is considered right or wrong. So let me know which route you'd like to take! Nice work so far though! |
My vote is for not having skittles buttons 🌈 Let's try out @jtomeck's color sense on this to see what it looks like. |
The `modules: true` rule allows for importing of typescript-built modules such as multinetjs (which includes an `import` statement that confuses the linter somehow). The `this: any` workaround avoids yet another instance of the difficulty of typechecking object-style components in Vue 2.x.
43d1bd4
to
42990c2
Compare
@jtomeck How's this look? |
- On successful table creation, redirect to that table detail page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thanks @AlmightyYakob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work that went into this, @AlmightyYakob!
Fixes #106.
This adds the UI for several key features:
A new dependency is added,
vue-json-pretty
, which allows for viewing the JSON results in a clean way.