Added ability to close transaction toasts on timeout #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/UI/TransactionsToastList/components/TransactionToast/hooks/useTransactionToast.ts
Outdated
Show resolved
Hide resolved
src/hooks/transactions/useTransactionsTracker/useCheckHangingTransactionsFallback.ts
Outdated
Show resolved
Hide resolved
src/hooks/transactions/useTransactionsTracker/useCheckHangingTransactionsFallback.ts
Outdated
Show resolved
Hide resolved
| @@ -10,23 +10,24 @@ import { | |||
| } from 'types'; | |||
| import { refreshAccount } from 'utils/account/refreshAccount'; | |||
|
|
|||
| export function useUpdateBatch() { | |||
| // TODO: This function seems duplicate to the manageTransaction from checkBatch.ts file | |||
There was a problem hiding this comment.
is it still used? why not combine them into one?
There was a problem hiding this comment.
This will be changed in the new sdk-dapp-core. why work on it twice?
There was a problem hiding this comment.
Yes, it is used for batch transactions
arhtudormorar
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Transaction toasts remain in infinite pending sometimes
Root cause
Websocket event is not triggered or API fails
Fix
Add fallback mechanism in useTransactionTracker for when WS fails
Additional changes
Improved websocket connection events handling
Contains breaking changes
Updated CHANGELOG
Testing