Skip to content

Commit

Permalink
incorporate feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
vbrunn committed Jan 7, 2025
1 parent a8c18b0 commit aab4d1f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 10 deletions.
11 changes: 10 additions & 1 deletion grass-gis-addons/m.import.rvr/m.import.rvr.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<h2>DESCRIPTION</h2>

<em>m.import.rvr</em> imports data for the processing of <b>buildings analysis</b>,
<b>green roofs</b> and/or <b>trees analysis</b>.
<b>green roofs</b>, <b>trees analysis</b> and/or ><b>neural network</b>.

The module takes as options the paths to the input directories and files.
With the flag <b>-c</b> the module checks only if all required input options
Expand Down Expand Up @@ -35,12 +35,21 @@ <h2>DESCRIPTION</h2>
<li><b>trees analysis</b>
<ul>
<li>True digital orthophotos (TOP): GTIFF files from given directory <b>top_dir</b> imported and resampled to 0.2 m</li>
<li>Reference buildings: imported from given vector file <b>reference_buildings_file</b> or from openNRW if <b>-b</b> is set</li>
<li>Digital surface model (DSM): LAZ files from given directory <b>dsm_dir</b> imported and resampled to 0.2 m</li>
<li>Digital terrain model (DTM): from given raster file <b>dtm_file</b>, or tiles from a directory with XYZ files, or if not set from openNRW imported and resampled to 0.2 m </li>
<li>Normalized Difference Vegetation Index (NDVI): calculated on the basis of <b>TOP</b> and scaled to 0 to 255</li>
<li>Normalized Digital Surface Model (nDSM): calculated on the basis of <b>DSM</b> and <b>DTM</b></li>
</ul>
</li>
<li><b>neural network</b>
<ul>
<li>True digital orthophotos (TOP): GTIFF files from given directory <b>top_dir</b> imported and resampled to 0.2 m</li>
<li>Digital surface model (DSM): LAZ files from given directory <b>dsm_dir</b> imported and resampled to 0.2 m</li>
<li>Digital terrain model (DTM): from given raster file <b>dtm_file</b>, or tiles from a directory with XYZ files, or if not set from openNRW imported and resampled to 0.2 m </li>
<li>Normalized Digital Surface Model (nDSM): calculated on the basis of <b>DSM</b> and <b>DTM</b></li>
</ul>
</li>
</ul>

<h2>REQUIREMENTS</h2>
Expand Down
18 changes: 9 additions & 9 deletions grass-gis-addons/m.import.rvr/m.import.rvr.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
#############################################################################

# %Module
# % description: Import data for the processing of buildings analysis, green roofs detection and/or trees analysis.
# % description: Import data for the processing of buildings analysis, green roofs detection, trees analysis and/or neural network.
# % keyword: raster
# % keyword: vector
# % keyword: import
# % keyword: trees analysis
# % keyword: buildings analysis
# % keyword: green roofs
# % keyword: neural network
# %end

# %option
Expand All @@ -33,7 +34,7 @@
# % required: yes
# % multiple: yes
# % label: Type of processing for which the data should be imported
# % options: buildings analysis,green roofs,trees analysis,train neural network
# % options: buildings analysis,green roofs,trees analysis,neural network
# % guisection: General input
# %end

Expand All @@ -48,7 +49,7 @@
# % key: dsm_dir
# % multiple: no
# % label: Directory where the digital surface model (DSM) is stored as laz files
# % description: Required for the processing types buildings analysis, green roofs detection and trees analysis
# % description: Required for the processing types buildings analysis, green roofs detection, trees analysis and neural network
# % guisection: General input
# %end

Expand All @@ -66,7 +67,7 @@
# % required: no
# % multiple: no
# % label: Directory where XYZ files of the digital terrain model (DTM) are stored (leave empty to automatically download DTM from Open.NRW)
# % description: Required for the processing types buildings analysis, green roofs detection and trees analysis
# % description: Required for the processing types buildings analysis, green roofs detection, trees analysis and neural network
# % guisection: General input
# %end

Expand All @@ -75,7 +76,7 @@
# % required: no
# % multiple: no
# % label: Raster file (e.g. TIF) of the digital terrain model (DTM) (leave empty to automatically download DTM from Open.NRW)
# % description: Required for the processing types buildings analysis, green roofs detection and trees analysis
# % description: Required for the processing types buildings analysis, green roofs detection, trees analysis and neural network
# % guisection: General input
# %end

Expand Down Expand Up @@ -166,7 +167,7 @@
# % required: no
# % multiple: no
# % label: Directory where the true digital orthophots (TOPs) are stored as GeoTiffs
# % description: Required for the processing of trees analysis
# % description: Required for the processing of trees analysis and neural network
# % guisection: Input trees analysis
# %end

Expand Down Expand Up @@ -284,10 +285,9 @@
"dtm": ([0.2], "ndsm", False, "dtm_file", "rasterORxyz"),
"ndsm": ([0.2], "output", True, "", "ndsm"),
},
"train neural network": {
"neural network": {
# raster
"top": ([0.2], "output,ndvi", True, "top_dir", "rasterdir"),
"ndvi": ([0.2], "output", True, "", "top_ndvi_scaled"),
"dsm": ([0.2], "ndsm", True, "dsm_dir", "lazdir"),
"dtm": ([0.2], "ndsm", False, "dtm_file", "rasterORxyz"),
"ndsm": ([0.2], "output", True, "", "ndsm"),
Expand Down Expand Up @@ -601,7 +601,7 @@ def check_data(ptype, data, val):
exists.
Args:
ptype (str): processing type (buildings analysis, green roofs,
trees analysis or train neural network)
trees analysis or neural network)
data (str): Name or type of the data
val (tuple): Tuple with values of the data: (resolution, purpose,
required, needed input information, import
Expand Down

0 comments on commit aab4d1f

Please sign in to comment.