Remove master configuration setting "use_default_node" #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting was introduced in 6adf38a. But somehow it partially lost its meaning in the merge commit c8228b8 (Merge branch 'sql' into devel). Afterwards it was only used for for breaking the node communication in case of a missing "host" attribute (which can never be empty as it is an integral part of the node specification in the master configuration). Thus it is not useful anymore. The purpose of this setting was later replaced with "use_node_name ignore" in dd4cbb5.
Pull Request Test Coverage Report for Build 2585
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting was introduced in 6adf38a.
But somehow it partially lost its meaning in the merge commit
c8228b8 (Merge branch 'sql' into devel).
Afterwards it was only used for for breaking the node communication
in case of a missing "host" attribute (which can never be empty as
it is an integral part of the node specification in the master
configuration). Thus it is not useful anymore.
The purpose of this setting was later replaced with
"use_node_name ignore" in dd4cbb5.