Skip to content

Update sunos iostat to cast values to integer #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update sunos iostat to cast values to integer #1596

wants to merge 1 commit into from

Conversation

@smokris
Copy link
Contributor

@smokris smokris commented Nov 22, 2023

For my SunOS/OpenSolaris/Illumos systems, I'm seeing error messages like this:

Error updating /var/lib/munin/…-iostat-diskr-d.rrd: /var/lib/munin/…-iostat-diskr-d.rrd: not a simple signed integer: '5769245279641.6'

Casting to integer enables this Munin plugin to correctly record data.

@smokris
Update sunos iostat to cast values to integer
5df9c67 
Avoids errors like `Error updating /var/lib/munin/…-iostat-diskr-d.rrd: /var/lib/munin/…-iostat-diskr-d.rrd: not a simple signed integer: '5769245279641.6'`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6961664628

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.182%
Totals Coverage Status
Change from base Build 6761952071: 0.0%
Covered Lines: 1577
Relevant Lines: 2247
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenyon kenyon kenyon approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smokris @coveralls @kenyon