TangoShutter: refactor (changes from https://github.com/mxcube/mxcubecore/pull/847/) #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally added in github.com/mxcube/pull/847
mockoocy
force-pushed
the
pm-add-tango-shutter-changes
branch
from
113fe3a to
26e1677
Compare
mockoocy
force-pushed
the
pm-add-tango-shutter-changes
branch
from
26e1677 to
acb0962
Compare
elmjag
reviewed
Feb 20, 2025
test/pytest/test_hwo_isara_maint.py
Outdated
| @@ -90,7 +90,7 @@ def disable_remote_mode(self): | |||
|
|
|||
| def _disconnect_channels(maint: ISARAMaint): | |||
| """ | |||
| disconnect signal callbacks from tango attribute pollers | |||
| disconnect signal callbacks from tango attribute pollersf | |||
There was a problem hiding this comment.
Tragedy in few parts:
- I opened this file
- I wanted to do
ctrl + fto search for something. - I must have missed the
ctrland pressedfn:D git add test/
There was a problem hiding this comment.
Removed the change now.
The ruff config had to be adjusted to ignore the rule saying that methods have to start with lowercase letter - as there is a mocked Tango Device.
mockoocy
force-pushed
the
pm-add-tango-shutter-changes
branch
from
acb0962 to
afb38fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code changes from PR #847
And a test case for the TangoShutter Hardware Object.
At MAXIV we use these changes for quite a long time, but it has not been merged in the original for some reason (which is rather unclear looking at the PR's discussion).
The difference between the version at #847 and this PR is addition of type annotations and adoption of new linting rules.