Don't call login_info twice on login/logout

mxcube · Dec 18, 2024 · 47bab68 · 47bab68
1 parent 045075a
commit 47bab68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/ui/src/components/App.jsx b/ui/src/components/App.jsx
@@ -73,8 +73,11 @@ function App() {
   const loggedIn = useSelector((state) => state.login.loggedIn);
 
   useEffect(() => {
+    // Fetch login info on mount
     dispatch(getLoginInfo()).catch(showBoundary); // eslint-disable-line promise/prefer-await-to-then
+  }, [dispatch, showBoundary]);
 
+  useEffect(() => {
     if (loggedIn) {
       serverIO.listen();
       const refreshInterval = setInterval(sendRefreshSession, REFRESH_INTERVAL);
@@ -87,7 +90,7 @@ function App() {
 
     // no clean-up required, until we connect to serverIO
     return undefined;
-  }, [loggedIn, dispatch, showBoundary]);
+  }, [loggedIn]);
 
   if (loggedIn === null) {
     // Fetching login info

diff --git a/ui/src/requests.js b/ui/src/requests.js