Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanling user "logged in" state in a more robust way in login_info #1513

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

marcus-oscarsson
Copy link
Member

@marcus-oscarsson marcus-oscarsson commented Dec 17, 2024

The request to login_info raised an exception and incorrectly returned a stack trace with the 200 status code.

The handling within login_info is perhaps still not ideal but this PR makes sure that the is_anonymous on current_user is updated correctly before the code that returns the user information is called. The "event" of "no valid sessions" should probably not be seen as an exception.

All requests raising an exceptions now returns a 501 without the traceback

Fixes #1477

@axelboc
Copy link
Collaborator

axelboc commented Dec 18, 2024

Fixes #1477 probably? (I've opened a ticket with our IT division about the conflicting timezone on Ubuntu 24.)

@marcus-oscarsson
Copy link
Member Author

:), thanks thats great because @walesch-yan also had the issue. I'm not sure it fixes the actual issue but you wont get it right away, I guess you would bump into the timezone issue at some point in anyways.

@marcus-oscarsson marcus-oscarsson merged commit 2df5c2c into develop Dec 19, 2024
16 of 17 checks passed
@marcus-oscarsson marcus-oscarsson deleted the mo-logininfo-fix branch December 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone error on Ubutun 24 silenced by login_info endpoint
2 participants