Merged
Conversation
Contributor
Author
|
I think there might be an error with 297e70e, Checking the supported modulation rate. MyConfig.h I think this will always be false since NRF5_250KBPS is an enum value, I'm assuming it's not defined when the preprocessor evaluates. |
Contributor
|
What do you think to set tthe default to 1mbps. |
Contributor
Author
|
Well, I started with that until I realized that my entire existing network is on 250KBPS, and they can't communicate at different bitrates. Users upgrading mysensors would have to reflash all of their existing nodes. It should probably happen at some point, but that would necessitate a significant user communication event. |
tekka007
pushed a commit
to tekka007/MySensors
that referenced
this pull request
Jul 25, 2022
* Exclude cache for NRF52805 * Check and handle unsupported modulation rates * Make PPI channel selection dynamic, based chip specific channel count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made few compatibility changes to address assumptions in the code that all NRF52 modules share the same peripherals.
These shouldn't be breaking changes, but they won't function until this is merged: