Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bucks] Add video to front page #4769

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Dec 14, 2023

Tidy up front page templates somewhat, and move Oxfordshire to lite embed to save c. 1MB in bandwidth!
[skip changelog]

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23cb599) 85.31% compared to head (3050787) 85.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4769      +/-   ##
==========================================
- Coverage   85.31%   85.31%   -0.01%     
==========================================
  Files         341      341              
  Lines       24638    24638              
  Branches     4676     4676              
==========================================
- Hits        21020    21019       -1     
- Misses       2197     2198       +1     
  Partials     1421     1421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos requested review from chrismytton and removed request for davea and lucascumsille December 15, 2023 09:07
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 📹

Was wondering about the other OCC video in the reporting flow, but I see that's lazy-loaded in a fancybox iframe, so guess not much benefit to using lite-yt there.

@dracos dracos merged commit 3050787 into master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants