Float the Continue button (and stopper/asset messaging) in initial steps of new report flow #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
+ Coverage 82.45% 82.49% +0.04%
==========================================
Files 417 417
Lines 33068 32994 -74
Branches 5326 5326
==========================================
- Hits 27265 27219 -46
+ Misses 4225 4197 -28
Partials 1578 1578 ☔ View full report in Codecov by Sentry. |
dracos
force-pushed
the
floating-continue
branch
from
849b649 to
cb3a375
Compare
dracos
force-pushed
the
floating-continue
branch
2 times, most recently
from
058561a to
653bf43
Compare
dracos
changed the title
dracos
changed the title
Check the new notification element for containing warning messages to show notificatins are being shown or not and remove the necessity for scrolling down in tests
Add to asset config:
construct_selected_asset_message: fixmystreet.assets.isleofwight.construct_message
asset_item_message: 'Please select an item or a road/pavement/path on the map »'
dracos
force-pushed
the
floating-continue
branch
from
8fee359 to
de2e59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make category button float in reporting, and bring asset/stopper messaging to floating button.
Fixes mysociety/societyworks#4760 (I put back the box-warning)
f94bf09 fixes mysociety/societyworks#4761
fdd099b and e8fe0e9 fixes mysociety/societyworks#4762
28c20d6 fixes mysociety/societyworks#4763
Fixes mysociety/societyworks#4764 (fixed calculation of padding height)
81c61c9 and db6e184 fixes mysociety/societyworks#4765
653bf43 fixes mysociety/societyworks#4766
Fixes mysociety/societyworks#4767 (various cobrand specific commits)