Change UNKNOWN_CODE_PLEASE_REPORT to identify uknown code#2516
Open
glensc wants to merge 1 commit intomysqljs:masterfrom
Open
Change UNKNOWN_CODE_PLEASE_REPORT to identify uknown code#2516glensc wants to merge 1 commit intomysqljs:masterfrom
glensc wants to merge 1 commit intomysqljs:masterfrom
Conversation
glensc
commented
Aug 9, 2021
glensc
force-pushed
the
patch-1
branch
2 times, most recently
from
7c9f847 to
c8970f4
Compare
dougwilson
requested changes
Sep 15, 2021
Member
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Please do not change the code property to be dymanic like this. The code property should work like it does in Node.js core as a single value without spaces. If you are trying to add the errno to the message, then just add it to the mesaage string.
Author
Changes UNKNOWN_CODE_PLEASE_REPORT to include packet.errno in it. This makes it easier to identify what the code is even if the code is not yet supported: ``` (node:1) UnhandledPromiseRejectionWarning: Error: UNKNOWN_CODE_PLEASE_REPORT: Query execution was interrupted, query_timeout exceeded ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
UNKNOWN_CODE_PLEASE_REPORTto includepacket.errnoin it.This makes it easier to identify what the code is even if the code is not yet supported: