This is a sample app with an easy-to-reproduce refresh issue found in the Store library. DbModels, Models, Room, Retrofit files are directly taken from the official library sample app. The main purpose is to show that after a few failing refresh attempts events are not delivered to the stream. The application structure is very basic and UI is not prepared to display the actual list of data (just informing that data has been successfully fetched). This repository has been created to make fixing this issue easier.
When there is an active stream collecting events and we want to refresh data quickly a few times with the network disabled we are causing the flow to break and stop delivering events.
I have investigated the problem a little bit in the code and my guess is that flow inside newDownstream inside Multicaster class is being finished/completed/canceled unexpectedly after a few StoreResponse.Error emissions, then new Multicaster via RefCountedResource create field is being recreated, new channels are being created as well and that is why events are not delivered to the stream anymore.
- Turn off plane mode/disable network connection.
- Launch the app.
- Click the refresh button couple of times.
- Events are not delivered to the stream after a few refresh attempts.
- Launch the app.
- Make a couple of successful attempts with network-enabled connection by clicking on the refresh button.
- Turn off plane mode/disable network connection.
- Click the refresh button couple of times.
- Events are not delivered to the stream after a few refresh attempts.
The stream should collect all the events even if they are occurring very fast and even if they are only network disabled errors.
Device: Pixel 6 (real device), also many AS emulators OS: Android 12 (API 31) Store Version: 4.0.5
Please take a look at the logcat for a better understanding. I have also recorded a video with
the issue: 