Merge pull request #60 from namecheap/feature/unload-ap

feat: unload app method
namecheap · Sep 6, 2024 · fcfa19d · fcfa19d
2 parents a58d6d8 + c72047d
commit fcfa19d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/app/GlobalBrowserApi.ts b/src/app/GlobalBrowserApi.ts
@@ -78,6 +78,10 @@ export class GlobalBrowserApi {
         return window.ILC.loadApp(name, options);
     }
 
+    static unloadApp(appId: string): void {
+        return window.ILC.unloadApp(appId);
+    }
+
     static getApplicationConfig<T extends object>(name: string): Promise<ApplicationConfig<T> | undefined> {
         return window.ILC.getApplicationConfigByName(name);
     }

diff --git a/src/app/window.d.ts b/src/app/window.d.ts
@@ -4,6 +4,7 @@ declare global {
     interface Window {
         ILC: {
             loadApp: (name: string, options?: { injectGlobalCss?: boolean }) => Promise<LifeCycles>;
+            unloadApp: (appId: string) => void;
             navigate: (url: string) => void;
             onIntlChange: (handler: (intlValues: { locale: string; currency: string }) => any) => void;
             onRouteChange: (

diff --git a/test/app/GlobalBrowserApi.spec.ts b/test/app/GlobalBrowserApi.spec.ts
@@ -50,6 +50,7 @@ describe('GlobalBrowserApi', () => {
             getSharedLibConfigByName: () => Promise.resolve([]),
             getSharedLibConfigByNameSync: () => [],
             getApplicationConfigByName: <T>() => Promise.resolve(appConfig as ApplicationConfig<T>),
+            unloadApp: (appId) => Promise.resolve(),
         };
     });
 
@@ -112,6 +113,9 @@ describe('GlobalBrowserApi', () => {
         const res = await GlobalBrowserApi.loadApp('@portal/news');
         expect(res).to.deep.eq(app);
     });
+    it('unloadApp is correctly typed and callable (no options arg)', async () => {
+        expect(GlobalBrowserApi.unloadApp('news_at_body')).to.be.fulfilled;
+    });
     it('loadApp is correctly typed and callable (empty option arg)', async () => {
         const res = await GlobalBrowserApi.loadApp('@portal/news', {});
         expect(res).to.deep.eq(app);