ci: add tubular in ci checks

[FBruzzesi]

What type of PR is this? (check all applicable)

• 💾 Refactor
• ✨ Feature
• 🐛 Bug Fix
• 🔧 Optimization
• 📝 Documentation
• ✅ Test
• 🐳 Other

Related issues

• Closes ci: add downstream tests for tubular #1202

Checklist

• Code follows style guide (ruff)
• Tests added
• Documented the changes

If you have comments or can explain your changes, please do so below.

[FBruzzesi]

Can't replicate the issue locally even with fresh new env. (link to failing action)

Error:

INTERNALERROR> pytest.PytestConfigWarning: Unknown config option: env

[DeaMariaLeon]

@FBruzzesi Would that have something to do with this line in Narwhals' pyproject.toml? :
env = [ "MODIN_ENGINE=python", ]

If so, should that environment variable be added? (to the tubular test section on .github/workflows/downstream_tests.yml that is being added).. Asking for a friend 🥸

[FBruzzesi]

@FBruzzesi Would that have something to do with this line in Narwhals' pyproject.toml? : env = [ "MODIN_ENGINE=python", ]

If so, should that environment variable be added? (to the tubular test section on .github/workflows/downstream_tests.yml that is being added).. Asking for a friend 🥸

I wonder why none of the other downstream test ends up with similar issue if that was the case! I will try to add the env variable (and pytest-env)

[DeaMariaLeon]

It went further!..

[FBruzzesi]

It went further!..

Yep yep, that was a good catch Dea, thanks for spotting it! Next issue ahead 😁🙈

Edit: The error was raised due to the filterwarnings settings in narwhals itself. By explicitly declaring which config file to use (pytest tests --config-file=pyproject.toml), locally I am not able to reproduce the issue.

I wonder if we should do the same with the other downstream libraries

[FBruzzesi]

Regarding marimo typecheck failing, seems we are missing some libraries?

[DeaMariaLeon]

I'm not sure if requesting me as a reviewer was an accident or a github bug 😆, but LGTM.

[MarcoGorelli]

thanks @FBruzzesi and @DeaMariaLeon !