Open
Conversation
for more information, see https://pre-commit.ci
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
Oh man, yes we can do that! In a way that's the largest diff 🤣 RE: typing, do you have any time/willing to take a stab at it? |
This comment was marked as resolved.
This comment was marked as resolved.
dangotbanned
reviewed
Apr 6, 2026
dangotbanned
reviewed
Apr 6, 2026
This comment was marked as outdated.
This comment was marked as outdated.
dangotbanned
approved these changes
Apr 13, 2026
Member
There was a problem hiding this comment.
Thanks @FBruzzesi, really appreciate the slog you've gone through on this one 😍
As mentioned on discord, most of the suggestions are about this:
Current:
- zip(...)
+ zip(..., strict=True)Proposed:
- zip(...)
+ zip(..., strict=False)We can always make more of them strict later if needed 🙂
Note
zip_strict -> zip(..., strict=True) is all good
Member
Author
|
@MarcoGorelli let me know if you are happy with this. I am happy to make a release before merging, so that some of the most recent features make it into a version that still support py3.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
It's likely that I have missed some branches that could be simplified due to newer python and bumping upstream min versions. Take this as a start to discuss in more detail
What type of PR is this? (check all applicable)
Related issues
3.9#3204