Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct links to GCN repository files in README.md #42

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

tylerbarna
Copy link
Member

Description

The links to relevant files in the GCN repository were from an outdated directory structure, resulting in the links being broken. These links are updated to point to the intended files as of June 2024.

It may be advisable to pin the links to a specific commit to ensure they don't break in the future if the structure of the GCN repository changes again

Related Issue(s)

Resolves #41

Testing

  1. Navigate to GCN links at the bottom of the README.md file to ensure they link to the proper files.

tylerbarna and others added 2 commits June 14, 2024 15:07
The links to relevant files in the GCN repository were from an outdated directory structure, resulting in the links being broken. These links are updated to point to the intended files as of June 2024.

It may be advisable to pin the links to a specific commit to ensure they don't break in the future if the structure of the GCN repository changes again
seems the latter two links were not updated when I submitted the PR through the github web interface
@lpsinger lpsinger merged commit f439046 into nasa-gcn:main Jun 16, 2024
7 checks passed
@tylerbarna tylerbarna deleted the patch-1 branch June 17, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md contains outdated links
2 participants