Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file comparison code with jest-file-snapshot #45

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

lpsinger
Copy link
Member

jest-file-snapshot produces nicer error messages and prints the
following helpful instructions if the tests fail:

Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `npm test -- -u` to update them.

jest-file-snapshot produces nicer error messages and prints the
following helpful instructions if the tests fail:

```
Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `npm test -- -u` to update them.
```
@lpsinger lpsinger requested review from Courey and dakota002 July 18, 2024 00:12
@lpsinger lpsinger force-pushed the jest-file-snapshot branch 3 times, most recently from 1605bd2 to 978ab05 Compare July 18, 2024 00:33
@lpsinger lpsinger force-pushed the jest-file-snapshot branch from 978ab05 to ed74a32 Compare July 18, 2024 00:36
@lpsinger lpsinger merged commit 32dec4d into nasa-gcn:main Jul 18, 2024
7 checks passed
@lpsinger lpsinger deleted the jest-file-snapshot branch July 18, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants