Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Issue #307 (bug on ECMWF retrievals) + documentation udpate + bug BRDF #310

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

juanchossn
Copy link
Contributor

Dear Dirk,

This PR is also huge, but properly segmented into corresponding commits:

-Bug fix (Issue #307), and adapting coding style to match HyperCP

-Avoid converting datetime object to string where unnecessary.

-Updates in README: Ancillary info and BRDF.

-Enhanced text in credentials pop-up window.

-oc_brdf: bug fix, keep BRDF=1 where BRDF fail flag is raised --> we are aligned with ThoMaS

-Updates in README: Ashleys contribution to unc(Rrs) description --> Ahsley sent this text so as to avoid merging conflicts in README_configuration.md

@oceancolorcoder oceancolorcoder merged commit 915ecb3 into nasa:dev Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants