Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct member index parsing to JSON loader #188

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

thomas-bc
Copy link
Collaborator

Related Issue(s) nasa/fprime#3168
Has Unit Tests (y/n) yes
Documentation Included (y/n)

Change Description

Fix nasa/fprime#3168

@thomas-bc thomas-bc requested a review from LeStarch January 30, 2025 02:18
bocchino
bocchino previously approved these changes Jan 30, 2025
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had one minor comment.

LeStarch
LeStarch previously approved these changes Jan 30, 2025
@thomas-bc thomas-bc merged commit 87baace into nasa:devel Jan 31, 2025
11 checks passed
@thomas-bc thomas-bc deleted the fix-dict-indexes branch January 31, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDS does not parse dictionary index field
3 participants