KMS-516: Fixed update to delete first, then update. #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There was a bug in the update, where if a user wanted to update a concept, it didn't delete the old concept first. As a result, duplicate fields were encountered.
What is the Solution?
I changed the logic to delete first, if there was an error in the delete, I also created a rollback function that will rollback the deleted triples (best I can do without transactions).
What areas of the application does this impact?
Updating SKOS concepts
Testing
Try creating a SKOS concept, then updating it where the updated version does not have some fields. Those fields should disappear when you try fetching the concept again.
Checklist