Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS-525b: Editing some of the fields #14

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

KMS-525b: Editing some of the fields #14

wants to merge 9 commits into from

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

The RDF file needed creationDate and edits to altLabel. Also added some retry logic to help convertFiles.js to keep from crashing out.

What is the Solution?

Summarize what you changed.

What areas of the application does this impact?

toRDF

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. Step 1
  2. Step 2...

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (4687368) to head (da37490).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   98.98%   99.15%   +0.16%     
==========================================
  Files          22       25       +3     
  Lines         297      353      +56     
  Branches       56       71      +15     
==========================================
+ Hits          294      350      +56     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandyparson mandyparson requested a review from cgokey February 18, 2025 22:04
@mandyparson mandyparson requested a review from htranho February 21, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants