Skip to content

Conversation

@htranho
Copy link
Contributor

@htranho htranho commented Sep 8, 2025

Overview

What is the feature?

'granuledataformat' is a valid scheme name parameter.

What is the Solution?

Accept scheme name parameter 'granuledataformat' and replace it with 'dataformat'.

What areas of the application does this impact?

/concepts, all formats, specially csv

Testing

http://localhost:3013/concepts/concept_scheme/granuledataformat?format=csv should works, no error message returned.

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (66f5f87) to head (e84760c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         139      139           
  Lines        2333     2334    +1     
  Branches      571      572    +1     
=======================================
+ Hits         2323     2324    +1     
  Misses          9        9           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

package.json Outdated
"@testing-library/react": "^14.1.2",
"@testing-library/user-event": "^14.5.1",
"@typescript-eslint/eslint-plugin": "^8.41.0",
"@typescript-eslint/eslint-plugin": "^8.42.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against doing this but, just keep in mind since we'll backport this we are gonna have some merge conflicts because of the CDK work on the package-lock file that I don't think we want to deal with

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, reverted to main branch version.

@htranho htranho merged commit 39b6a06 into main Sep 9, 2025
6 checks passed
@htranho htranho deleted the KMS-625 branch September 9, 2025 19:21
eudoroolivares2016 pushed a commit that referenced this pull request Sep 10, 2025
* KMS-625: Fix csv issue with 'granuledataformat'

* KMS-625: Revert to package* files from main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants