Skip to content

Conversation

@htranho
Copy link
Contributor

@htranho htranho commented Sep 8, 2025

Overview

What is the feature?

Deleted concept still show up.

What is the Solution?

Issue was that change notes were added to the deleted concept, so it still has data after deleting.

What areas of the application does this impact?

DELETE on /concept

Testing

  1. Send DELETE to a leaf concept example http://127.0.0.1:3013/concept/030470d1-f545-4775-90b3-b12978cd6315?version=draft
  2. http://127.0.0.1:3013/concept/030470d1-f545-4775-90b3-b12978cd6315?version=draft should return {"error":"Concept not found"}

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (66f5f87) to head (28695d5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files         139      139              
  Lines        2333     2329       -4     
  Branches      571      571              
==========================================
- Hits         2323     2319       -4     
  Misses          9        9              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

)
})
})
// Commented out because we want to preserve this test code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking rather than keeping all these comments in the code, maybe in KMS-631 ticket can you reference this commit:
1c3971e

Then the code is cleaned up from comments but we still. preserve what we need to put back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@htranho htranho merged commit aa2d261 into main Sep 12, 2025
6 checks passed
@htranho htranho deleted the KMS-630 branch September 12, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants