Skip to content

Conversation

@cgokey
Copy link
Contributor

@cgokey cgokey commented Sep 10, 2025

Overview

What is the feature?

Fix issue where instant refresh never completes.

What is the Solution?

Simplify ASG and Add Instance Refresh Script

  1. ASG Changes:

    • Removed 'EbsAzHook' lifecycle hook
    • Simplified instance launch process
    • Rationale: CDK handles AZ placement; reduces complexity so hook not necessary
  2. New RDF4J Instance Refresh Script:

    • Purpose: Controlled instance refresh for single-instance RDF4J setup
    • Process: Shutdown old instance, start new one, verify ECS stability
    • Ensures only one instance runs at a time (RDF4J 1-writer constraint)
    • Use cases: AMI updates, config changes, controlled restarts

Impact: Streamlined infrastructure, resolved termination issues,
safer instance management for RDF4J database.

What areas of the application does this impact?

AMI updates that occur every 90 days.

Testing

cd kms/bin
./refresh_asg.sh

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (39b6a06) to head (04669b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         139      139           
  Lines        2334     2334           
  Branches      572      572           
=======================================
  Hits         2324     2324           
  Misses          9        9           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cgokey cgokey merged commit f017ffa into main Sep 16, 2025
6 checks passed
@cgokey cgokey deleted the KMS-633 branch September 16, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants