Skip to content

Conversation

@cgokey
Copy link
Contributor

@cgokey cgokey commented Oct 6, 2025

Overview

What is the feature?

The export-rdf-to-s3 lambda is not able to write to the s3 bucket kms-ref-backup-ops, we are not seeing any past published versions being archived.

What is the Solution?

The S3 access policy only includes arn:aws:s3:::kms-rdf-backup-${stage} and since stage is sit, uat, and prod, the never gives permissions to -ops. This change updates the access policy to include -ops as well.

Note, I thought about seeing if I can rename the bucket, but in aws this is not possible, so think we should just deploy with this new access policy.

I should also note, the mdt bucket is not needed that was left in there by accident, it was the bucket I was using for testing in the MDT ngap account.

What areas of the application does this impact?

Export of past archived versions to s3.

Testing

Verify that we are seeing drafts and past published versions written to s3 after this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (f017ffa) to head (d555c8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         139      139           
  Lines        2329     2329           
  Branches      571      570    -1     
=======================================
  Hits         2319     2319           
  Misses          9        9           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eudoroolivares2016 eudoroolivares2016 changed the title KMS-638: Updated s3 access poligy to include -ops as well. KMS-638: Updated s3 access policy to include -ops as well. Oct 6, 2025
@eudoroolivares2016
Copy link

Porting DM conversation. We should update so we can deprecate the bucket name env var and just use the stage var

@cgokey cgokey merged commit c714186 into main Oct 8, 2025
6 checks passed
@cgokey cgokey deleted the KMS-638 branch October 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants