Fix: Condition Sets Incorrectly Evaluate Infrequent Telemetry Updates #8002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7992
Condition sets can incorrectly evaluate telemetry objects that update infrequently due to short-circuit evaluation. This causes stale results and incorrect conditional styling. The issue occurs because the evaluation stops when a condition evaluates to
true
, preventing subsequent conditions from being re-evaluated with the latest telemetry data.Fix
Removed short-circuiting in the
updateConditionResults
method to ensure all conditions are re-evaluated with the latest telemetry data. This prevents stale results and ensures that the condition set's state is always accurate.Changes
updateConditionResults
to iterate over all conditions and update their results, regardless of whether a previous condition evaluated totrue
.Impact