Recorder/Sender の setting を ScriptableObject で保存する

Assets/ArtNet/Editor/DmxRecorder/DmxRecordWindow.cs

@@ -1,4 +1,3 @@
-using System;
 using UnityEditor;
 using UnityEngine;
 using UnityEngine.UIElements;
@@ -36,6 +35,11 @@ public void CreateGUI()
             Initialize(visualElement);
         }
 
+        private void OnDestroy()
+        {
+            SaveConfig();
+        }
+
         [MenuItem("ArtNet/DmxRecorder")]
         public static void ShowDmxRecorder()
         {
@@ -45,6 +49,8 @@ public static void ShowDmxRecorder()
 
         private void Initialize(VisualElement root)
         {
+            _recorder.RecorderSettings = RecorderSettings.GetOrNewGlobalSettings();
+
             var tabContent = new VisualElement { name = "tabContent" };
             root.Add(tabContent);
 
@@ -55,21 +61,6 @@ private void Initialize(VisualElement root)
             senderVisualElement.name = "senderPanel";
             tabContent.Add(senderVisualElement);
 
-            var recordFormatStringType = EditorUserSettings.GetConfigValue(EditorSettingKey("OutputFormat")) ??
-                                         RecodeFormat.Binary.ToString();
-            var format = (RecodeFormat) Enum.Parse(typeof(RecodeFormat), recordFormatStringType);
-            var binaryRecordConfig = new BinaryRecordConfig
-            {
-                Directory = EditorUserSettings.GetConfigValue(EditorSettingKey("OutputDirectory")) ??
-                            Application.dataPath,
-                FileName = EditorUserSettings.GetConfigValue(EditorSettingKey("OutputFileName")) ??
-                           "dmx-record",
-            };
-
-            var animationClipRecordConfig = new AnimationClipRecordConfig();
-
-            _recorder.RecordConfigs = new RecordConfigs(format, binaryRecordConfig, animationClipRecordConfig);
-
             InitializeHeaderTab(root);
             InitializeRecorder(recorderVisualElement);
             InitializeSender(senderVisualElement);
@@ -105,7 +96,5 @@ private void InitializeHeaderTab(VisualElement root)
                 recorderPanel.style.display = DisplayStyle.None;
             });
         }
-
-        private static string EditorSettingKey(string key) => $"{EditorSettingPrefix}{key}";
     }
 }

Assets/ArtNet/Editor/DmxRecorder/Recorder.cs

@@ -29,7 +29,7 @@ public Recorder()
             _receiver.OnReceivedPacket = OnReceivedPacket;
         }
         public RecordingStatus Status { get; private set; } = RecordingStatus.None;
-        public RecordConfigs RecordConfigs { get; set; }
+        public RecorderSettings RecorderSettings { get; set; }
 
         public int GetRecordedCount() => _recordedDmx.Count;
 
@@ -124,7 +124,7 @@ private void StoreDmxPacket()
                 return;
             }
 
-            switch (RecordConfigs.RecordFormat)
+            switch (RecorderSettings.RecordFormat)
             {
                 case RecodeFormat.Binary:
                     StoreBinary();
@@ -139,7 +139,7 @@ private void StoreDmxPacket()
 
         private void StoreBinary()
         {
-            var binaryConfig = RecordConfigs.BinaryConfig;
+            var binaryConfig = RecorderSettings.BinarySetting;
 
             if (!Directory.Exists(binaryConfig.Directory))
             {
@@ -157,7 +157,7 @@ private void StoreBinary()
 
         private void StoreAnimationClip()
         {
-            var animationClipConfig = RecordConfigs.AnimationClipConfig;
+            var animationClipConfig = RecorderSettings.AnimationClipSetting;
             var timelineConverter = new TimelineConverter(_recordedDmx);
             timelineConverter.SaveDmxTimelineClips(animationClipConfig.OutputAnimationClipAssetPath);
         }

Assets/ArtNet/Editor/DmxRecorder/RecorderSettings.cs

@@ -0,0 +1,136 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using UnityEditor;
+using UnityEditorInternal;
+using UnityEngine;
+using Object = UnityEngine.Object;
+
+namespace ArtNet.Editor.DmxRecorder
+{
+    public enum RecodeFormat
+    {
+        Binary = 0,
+        AnimationClip = 1,
+    }
+
+    public class RecorderSettings : ScriptableObject
+    {
+        [SerializeField] private RecodeFormat _recordFormat;
+
+        private string _savePath;
+
+        public RecodeFormat RecordFormat => _recordFormat;
+
+        public BinaryRecordSetting BinarySetting { get; } = new();
+        public AnimationClipRecordSetting AnimationClipSetting { get; } = new();
+
+        public static RecorderSettings GetOrNewGlobalSettings()
+        {
+            var globalPath = Path.Combine(Application.dataPath, "..", "Library", "ArtNet", "DmxRecorderSettings.asset");
+            return Load(globalPath);
+        }
+
+        private static RecorderSettings Load(string path)
+        {
+            RecorderSettings settings;
+            try
+            {
+                var objs = InternalEditorUtility.LoadSerializedFileAndForget(path);
+                settings = objs.FirstOrDefault(o => o is RecorderSettings) as RecorderSettings;
+            }
+            catch (Exception e)
+            {
+                Debug.LogError($"Failed to load RecorderSettings: {e.Message}");
+                settings = null;
+            }
+
+            if (settings == null)
+            {
+                settings = CreateInstance<RecorderSettings>();
+                // Settings.hideFlags = HideFlags.HideAndDontSave;
+                settings.name = "DmxRecorderSettings";
+            }
+
+            settings._savePath = path;
+            return settings;
+        }
+
+        public void Save()
+        {
+            if (string.IsNullOrEmpty(_savePath)) return;
+
+            try
+            {
+                var directory = Path.GetDirectoryName(_savePath);
+                if (!string.IsNullOrEmpty(directory) && !Directory.Exists(directory))
+                    Directory.CreateDirectory(directory);
+
+                var objs = new Object[] { this };
+                InternalEditorUtility.SaveToSerializedFileAndForget(objs, _savePath, true);
+            }
+            catch (Exception e)
+            {
+                Debug.LogError($"Failed to save RecorderSettings: {e.Message}");
+            }
+        }
+
+        public void ChangeRecordFormat(RecodeFormat format)
+        {
+            EditorUtility.SetDirty(this);
+            Undo.RecordObject(this, "Change Record Format");
+            if (_recordFormat == format) return;
+
+            _recordFormat = format;
+            Save();
+        }
+
+        private IRecordSetting Setting => RecordFormat switch
+        {
+            RecodeFormat.Binary => BinarySetting,
+            RecodeFormat.AnimationClip => AnimationClipSetting,
+            _ => throw new System.NotImplementedException()
+        };
+
+        public bool Validate() => ValidateErrors().Count == 0;
+        public List<string> ValidateErrors() => Setting.ValidateErrors();
+    }
+
+    public class BinaryRecordSetting : IRecordSetting
+    {
+        private const string Extension = ".dmx";
+
+        public string Directory { get; set; }
+        public string FileName { get; set; }
+
+        public string OutputPath => $"{Directory}/{FileName}{Extension}";
+
+        public List<string> ValidateErrors()
+        {
+            var errors = new List<string>();
+            if (!ValidateDirectory()) errors.Add("Directory is not set");
+            if (!ValidateFileName()) errors.Add("FileName is not set");
+
+            return errors;
+        }
+
+        private bool ValidateDirectory() => !string.IsNullOrEmpty(Directory);
+        private bool ValidateFileName() => !string.IsNullOrEmpty(FileName);
+    }
+
+    public class AnimationClipRecordSetting : IRecordSetting
+    {
+        public string OutputAnimationClipAssetPath { get; set; } = "Assets/Recording";
+
+        public List<string> ValidateErrors()
+        {
+            return new List<string>();
+        }
+    }
+
+    public interface IRecordSetting
+    {
+        public List<string> ValidateErrors();
+    }
+}