Update 2-playground-tutorial.md #162
Conversation
Hi there, I've followed this tutorial and I think on the function to add Todo does not validate user input for empty string. So i'm propose some minor change. Thank you
|
Deploy preview for nativescript-vue ready! Built with commit 6f50882 |
|
Thanks for the updates @muhibbudins! |
| @@ -229,6 +229,7 @@ new Vue({ | |||
| console.log('Task with index: ' + args.index + ' tapped'); // Logs tapped tasks in the console for debugging. | |||
| }, | |||
| onButtonTap() { | |||
| if (this.textFieldValue === "") return // Prevent user input empty string | |||
There was a problem hiding this comment.
Two things here:
- The semi-colon is missing at the end of the line
- Please, pay attention to the format of code comments above and below and fix it for consistency. Ideally, here you would go with something like "Prevents users from entering an empty string."
There was a problem hiding this comment.
Hi @ikoevska ,
Sorry for the mistakes, i've updated the code. Thanks
|
Sorry about that but I missed it the first time around. We need to have this line added to all code blocks for onButtonTap (there are two more instances across the file). Otherwise, it will get lost across code sanity checks. As a note to self and @rigor789 , we should probably have a better way to include identical code in several places... Ideas? |
|
@ikoevska I left an idea comment here: #163 (comment) |
|
Addressed in #232. Closing :) |
Hi there,
I've followed this tutorial and I think on the function to add Todo does not validate user input for empty string.
So i'm propose some minor change.
Thank you