Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Make sure to always remove internal clients from the account regardless of kind. #5566

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

derekcollison
Copy link
Member

Internal clients for NRG (Raft Groups) were of type SYSTEM and were not being removed from the system's account when they were closed, causing a leak of closed client connections and memory buildup.

Resolves: #5471

Signed-off-by: Derek Collison [email protected]

@derekcollison derekcollison requested a review from a team as a code owner June 19, 2024 21:42
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit e2752d5 into main Jun 19, 2024
4 checks passed
@derekcollison derekcollison deleted the fix-5471 branch June 19, 2024 22:05
neilalexander added a commit that referenced this pull request Jun 19, 2024
Includes the following:

* #5566
* #5568 

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT Memory Leaks on consumer connections
2 participants